Skip to content

Close all owned module sessions in PerpetualTradingClient.close() #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikions wants to merge 1 commit into
base: starknet
Choose a base branch
from
Open

Close all owned module sessions in PerpetualTradingClient.close() #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/perpetual/test_trading_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,3 +170,24 @@ async def test_get_asset_operations(aiohttp_server, create_asset_operations, cre
]
),
)


@pytest.mark.asyncio
async def test_close_closes_all_module_sessions():
from x10.perpetual.trading_client import PerpetualTradingClient

trading_client = PerpetualTradingClient(endpoint_config=TESTNET_CONFIG)

sessions = [
await trading_client.info.get_session(),
await trading_client.markets_info.get_session(),
await trading_client.account.get_session(),
await trading_client.orders.get_session(),
await trading_client.vault.get_session(),
await trading_client.testnet.get_session(),
]

await trading_client.close()

for session in sessions:
assert session.closed
3 changes: 3 additions & 0 deletions x10/perpetual/trading_client/trading_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,12 @@ async def place_order(
return await self.__order_management_module.place_order(order)

async def close(self):
await self.__info_module.close_session()
await self.__info_markets_module.close_session()
await self.__account_module.close_session()
await self.__order_management_module.close_session()
await self.__vault_module.close_session()
await self.__testnet_module.close_session()

async def __aenter__(self):
return self
Expand Down