Feature/endpoint stack#5
Open
sfsekaran wants to merge 2 commits into
Open
Conversation
…an be nested and it restores the previous endpoint after an activate_with block ends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing I've noticed is that some specs don't pass anymore (some issue with ports). I haven't tried to ameliorate that issue.
However, I have added a few passing specs and code which add some useful functionality. Namely, making it so @Artifice.activate_with(q) do ... end@ restores the previous rack endpoint after the end of the block if Artifice was already activated when the @activate_with@ block was called.
We needed our Artifice blocks not to deactivate artifice after running because we were using a global endpoint and specific endpoints in our tests.
I've updated the README so you can see what the use cases are.