Added support for reactivation#10
Open
theconektd wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I've gone back and forth on this one and I think I still like it. At the end of the day, it's easy to dig your last endpoint out of Artifice and just bolt it back on, but this approach doesn't require the user to have any knowledge of the internals. I'm wondering if there should be a Artifice.previously_activated? method. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an Artifice.reactivate method. It supports the same style as activate_with, but just mounts the last used endpoint.
It may seem hard to justify, but this is actually really useful for (ahem) "a special case" we're dealing with in one of our suites and I suspect it could be useful for others as well.