Skip to content

fix(panel): clamp panel window height to screen (#304) #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LikeSundayLikeRain wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(panel): clamp panel window height to screen (#304) #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Sources/CodeIsland/PanelWindowController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,15 @@ class PanelWindowController: NSObject, NSWindowDelegate {

private func panelSize(for screen: NSScreen) -> NSSize {
let maxSessions = CGFloat(max(2, UserDefaults.standard.integer(forKey: SettingsKey.maxVisibleSessions)))
let maxH = max(300, maxSessions * 90 + 60)
let desiredH = max(300, maxSessions * 90 + 60)
// Clamp to the screen's usable height. A borderless, non-opaque panel with a
// very tall backing store (e.g. maxVisibleSessions=99 → 8970pt, ~18k px tall on
// a Retina display) has its compositing dropped by the macOS 26 WindowServer
// once the surface goes idle — the card renders blank until a mouse event forces
// a redraw, which looked like "invisible after ~2s, reappears on hover" (#304).
// The content is top-anchored and the session list scrolls internally, so the
// window never needs to be taller than the visible screen.
let maxH = min(desiredH, screen.visibleFrame.height)
let screenW = screen.frame.width
let width = min(620, screenW - 40)
return NSSize(width: width, height: maxH)
Expand Down