Docs: PV migration to SSD - #155
Open
ArtisKrumins wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Several runbook steps/wording are internally inconsistent or overly hardcoded (e.g., StatefulSet orphaning references and StorageClass values), which could lead to operators executing incorrect actions during a migration/rollback.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds an operational runbook documenting how to migrate a GKE Persistent Volume from the legacy in-tree kubernetes.io/gce-pd driver to the GKE PD CSI driver (pd.csi.storage.gke.io) by snapshotting the underlying disk, creating a new SSD-backed disk, and re-binding a PVC with the original name (plus a rollback path).
Changes:
- Introduces a step-by-step PV/PVC migration procedure (snapshot → new disk → static PV/PVC bind).
- Documents a rollback procedure using the retained original PV.
- Provides reusable placeholders for environment-specific values (namespace, PV/PVC names, project, zone, etc.).
File summaries
| File | Description |
|---|---|
| docs/gke-pv-migration-runbook.md | New runbook describing PV migration to CSI/SSD plus rollback steps |
Review details
Suppressed comments (2)
docs/gke-pv-migration-runbook.md:122
- This PVC hardcodes
storageClassName: premium-rwo. For static binding, it must match the PV’s storageClassName; use the same placeholder to avoid mismatches.
storageClassName: premium-rwo
docs/gke-pv-migration-runbook.md:201
- Rollback instructions are vague ("Edit storage type back to previous") and again say "Remove StatefulSet orphaning" while the command orphan-deletes the StatefulSet. Make the instruction explicit (update Helm values/manifests back to the original StorageClass) and fix the wording to match the command.
Edit storage type back to previous.
Remove StatefulSet orphaning to allow Helm to manage the new PVC and PV definitions cleanly.
- Files reviewed: 1/1 changed files
- Comments generated: 8
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+9
to
+20
| | Placeholder | Meaning | | ||
| | --- | --- | | ||
| | `[namespace]` | Namespace of the workload | | ||
| | `[original-pvc-name]` | Existing PVC name (reused at the end) | | ||
| | `[statefulset-name]` | Workload StatefulSet | | ||
| | `[snapshot-name]` | Name for the GCP disk snapshot | | ||
| | `[new-disk-name]` | Name for the new `pd-ssd` disk | | ||
| | `[migrated-pv-name]` | Name for the new statically bound PV | | ||
| | `[original-pv-name]` | Original PV name (value of `$PV_NAME`) | | ||
| | `[gke-project-id]` | GCP project ID | | ||
| | `[gcp-zone]` | Zone of the disk (value of `$GCP_ZONE`) | | ||
| | `[disk-size]` | Disk size, e.g. `500Gi` | |
| accessModes: | ||
| - ReadWriteOnce | ||
| persistentVolumeReclaimPolicy: Retain | ||
| storageClassName: premium-rwo |
| spec: | ||
| accessModes: | ||
| - ReadWriteOnce | ||
| storageClassName: standard # Original storage class |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Jancis
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.