Updated default values for openshift#233
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummaryUpdated default values for OpenShift deployments in the Helm chart. The changes configure OpenShift-specific routing and ingress settings for the API Manager deployment. Changes MadeFile:
The changes align the OpenShift default values file with the proper routing mechanism for OpenShift environments while maintaining compatibility with standard Kubernetes deployments through separate configuration paths. Lines changed: +47/-4 WalkthroughThis PR modifies the default OpenShift Helm values file to switch from Kubernetes Ingress to OpenShift Routes. The changes enable the OpenShift platform configuration with gatewayAPI support, disable Kubernetes Ingress for management and gateway endpoints, disable websocket and websub Ingress resources, and introduce OpenShift route configuration with TLS passthrough mode for management, gateway, websocket, and websub endpoints. Each route includes hostname configuration and placeholder annotation blocks. Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Included routes block to openshift-default-vals
Changes
all-in-one/default_openshift_values.yamlwith missing routes block and additional default values