Skip to content

Updated default values for openshift#233

Merged
kavindasr merged 2 commits into
wso2:mainfrom
Saadha123:fix/openshift-default-vals-main
May 22, 2026
Merged

Updated default values for openshift#233
kavindasr merged 2 commits into
wso2:mainfrom
Saadha123:fix/openshift-default-vals-main

Conversation

@Saadha123
Copy link
Copy Markdown
Contributor

Purpose

Included routes block to openshift-default-vals

Changes

  • Updated all-in-one/default_openshift_values.yaml with missing routes block and additional default values

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 598194a0-684c-4407-ade8-a6023f952495

📥 Commits

Reviewing files that changed from the base of the PR and between 661058a and 250e452.

📒 Files selected for processing (1)
  • all-in-one/default_openshift_values.yaml

📝 Walkthrough

Summary

Updated default values for OpenShift deployments in the Helm chart. The changes configure OpenShift-specific routing and ingress settings for the API Manager deployment.

Changes Made

File: all-in-one/default_openshift_values.yaml

  • Enabled OpenShift support (kubernetes.openshift.enabled: true)
  • Disabled standard Kubernetes ingress for management and gateway endpoints (kubernetes.ingress.management.enabled and kubernetes.ingress.gateway.enabled set to false)
  • Disabled websocket and websub ingress endpoints
  • Added OpenShift route configuration block with the following:
    • TLS termination type set to passthrough
    • Routes enabled for management, gateway, websocket, and websub with configurable hostnames
    • Support for custom annotations on each route
    • Insecure edge termination policy set to None
    • Support for optional TLS certificates and keys for different termination modes

The changes align the OpenShift default values file with the proper routing mechanism for OpenShift environments while maintaining compatibility with standard Kubernetes deployments through separate configuration paths.

Lines changed: +47/-4

Walkthrough

This PR modifies the default OpenShift Helm values file to switch from Kubernetes Ingress to OpenShift Routes. The changes enable the OpenShift platform configuration with gatewayAPI support, disable Kubernetes Ingress for management and gateway endpoints, disable websocket and websub Ingress resources, and introduce OpenShift route configuration with TLS passthrough mode for management, gateway, websocket, and websub endpoints. Each route includes hostname configuration and placeholder annotation blocks.

Suggested reviewers

  • kavindasr
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. Only Purpose and Changes sections are provided; all other required sections from the template are missing or unfilled. Complete the description using the template: add Goals, Approach, User stories, Release note, Documentation, Training, Certification, Marketing, Automation tests, Security checks, Samples, Related PRs, Migrations, Test environment, and Learning sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating default values specifically for OpenShift configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kavindasr kavindasr merged commit acedefe into wso2:main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants