Fix: Incorrect SAML assertion consumer URL configuration for all affected versions (Product IS issue #27581)#6069
Open
wso2-engineering-bot wants to merge 1 commit intomasterfrom
Conversation
…cted versions (product-is#27581) Added missing [authentication.authenticator.saml.parameters] section in the SAML 2.0 Web SSO configuration documentation. This fix aligns versions 5.9.0, 5.10.0, 6.0.0, and 6.1.0 with the correct configuration format already applied to version 5.11.0. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
wso2-engineering-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
📝 WalkthroughWalkthroughDocumentation updates across four Identity Server versions (5.9.0, 5.10.0, 6.0.0, 6.1.0) to fix SAML 2.0 Web SSO configuration. Each file now includes the Changes
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
en/identity-server/5.10.0/docs/learn/configuring-saml-2.0-web-sso.md (1)
13-13:⚠️ Potential issue | 🔴 CriticalFix trailing space to resolve pipeline failure.
The Markdown linter reports trailing spaces on this line, causing the CI pipeline to fail. Remove the trailing space at the end of line 13.
🐛 Proposed fix
-SAML 2.0 [Profiles specification](http://www.oasis-open.org/committees/download.php/35389/sstc-saml-profiles-errata-2.0-wd-06-diff.pdf). +SAML 2.0 [Profiles specification](http://www.oasis-open.org/committees/download.php/35389/sstc-saml-profiles-errata-2.0-wd-06-diff.pdf).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/identity-server/5.10.0/docs/learn/configuring-saml-2.0-web-sso.md` at line 13, Remove the trailing whitespace at the end of the Markdown line containing "SAML 2.0 [Profiles specification](http://www.oasis-open.org/committees/download.php/35389/sstc-saml-profiles-errata-2.0-wd-06-diff.pdf)." so the line no longer ends with an extra space; this will satisfy the Markdown linter and fix the CI pipeline failure.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@en/identity-server/5.10.0/docs/learn/configuring-saml-2.0-web-sso.md`:
- Line 13: Remove the trailing whitespace at the end of the Markdown line
containing "SAML 2.0 [Profiles
specification](http://www.oasis-open.org/committees/download.php/35389/sstc-saml-profiles-errata-2.0-wd-06-diff.pdf)."
so the line no longer ends with an extra space; this will satisfy the Markdown
linter and fix the CI pipeline failure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: bd8ad7ea-6263-4c21-b972-7b7ff6a491a3
📒 Files selected for processing (4)
en/identity-server/5.10.0/docs/learn/configuring-saml-2.0-web-sso.mden/identity-server/5.9.0/docs/learn/configuring-saml-2.0-web-sso.mden/identity-server/6.0.0/docs/guides/identity-federation/configure-saml-2.0-web-sso.mden/identity-server/6.1.0/docs/guides/identity-federation/configure-saml-2.0-web-sso.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated by Claude AI.
[authentication.authenticator.saml.parameters]section in the SAML 2.0 Web SSO configuration documentation. TheSAMLSSOAssertionConsumerUrlparameter was incorrectly placed directly under[authentication.authenticator.saml]instead of under the[authentication.authenticator.saml.parameters]section.Changes:
en/identity-server/5.9.0/docs/learn/configuring-saml-2.0-web-sso.mden/identity-server/5.10.0/docs/learn/configuring-saml-2.0-web-sso.mden/identity-server/6.0.0/docs/guides/identity-federation/configure-saml-2.0-web-sso.mden/identity-server/6.1.0/docs/guides/identity-federation/configure-saml-2.0-web-sso.mdNote: The
mkdocs build --stricttest encounters pre-existing warnings/errors in the repository that are unrelated to these changes (verified by testing version 5.11.0 which also fails strict mode). The changes made are syntactically correct and match the approved fix from PR #2947.