feat: add email domain health workflow and security page polish#104
Conversation
Introduce end-to-end domain health checks (SPF/DKIM/DMARC), persistence, and UI surfaces so operators can triage mail-auth posture from Security Graph and a dedicated page. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
304af3d to
ce5989f
Compare
|
Droid finished @dcoln25-writer's task —— View job The Email Domain Health feature is well structured: handlers are session-authenticated and scoped by |
|
Droid encountered an error —— View job Droid is reviewing code and running a security check… |
|
Droid finished @dcoln25-writer's task —— View job The Email Domain Health feature is well structured and the two prior review comments (DKIM key-bit calculation and refresh-handler throttling) are addressed at this head SHA. The main remaining concern is that the list/ensure read path still performs unbounded, unthrottled outbound DNS on every page load, lacking the rate limit and bulk cap applied to the refresh handler. Secondary correctness issues are an Ed25519 DKIM false-positive that forces domains to FAILING and an empty refresh-all response when no domains are stale. |
|
Droid encountered an error —— View job Droid is reviewing code and running a security check… |
|
Droid finished @dcoln25-writer's task —— View job The Email Domain Health feature is well structured, and all five previously flagged issues (DKIM key-bit calculation, list/refresh DNS rate-limiting, Ed25519 false-positive, and refresh-all empty result) are resolved at this head SHA. Remaining items are non-blocking: the |
|
Droid encountered an error —— View job Droid is reviewing code and running a security check… |
Add Salesforce provider/catalog support (Connected App client ID+secret flow), tighten connector rules UX, and remove the legacy per-connector Checks dialog. Harden email-domain health with accurate DKIM key sizing, Ed25519 support, list/get/refresh throttling and caps, sanitized DNS lookup error details, and complete discovered-domain list responses; also fix sidebar nested active-state highlighting. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Repushed at . Addressed the follow-up review items on this branch:
|
|
Repushed at Addressed the follow-up review items on this branch:
|
|
Droid finished @dcoln25-writer's task —— View job No issues found. The Email Domain Health feature is well structured: handlers are session-authenticated and org-scoped, SQL is parameterized, and DNS read/refresh paths are rate-limited and bulk-capped. All previously flagged issues are resolved at this head SHA and no new high-confidence, actionable issues were found. |
Summary
/security/email-domain-healthpage?allp=tonone|quarantine|rejectp=key material as an issue (not healthy)saas_identitiesemail/external identifiers so domains are found even when integration account ids are slugsValidation
go build ./...go vet ./...go test ./... -shortnpm run typechecknpm run test:apinpm run build:web