ci: build/lint gate for macOS, Windows and Linux - #7
Merged
Conversation
BHServe ships three front-ends (Swift/macOS, C#/Windows, Python/Linux) over one
shared bash engine, and nothing ever compiled the other platforms. A community PR
sat open containing C# pattern-matching syntax pasted into a .swift file (which
cannot compile) plus a deleted Python variable that was still referenced — a
runtime NameError PyGObject swallows, so the button silently did nothing.
- macOS: swift build
- Windows: dotnet build BHServe.sln
- Linux: compileall + ruff F821/F822 (undefined names — the class py_compile
cannot see) + bash -n over the engine and every shipped .sh
Narrow rule set on purpose: a correctness gate, not a style gate, so it never
fails a PR over formatting. Jobs are per-platform so a Linux-only change is not
blocked by a Windows job.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ils" This reverts commit 6d09b30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing build CI. Catches the two bug classes found while reviewing #5/#6: Swift that can't compile, and Python undefined names (
NameErrorat runtime, invisible topy_compile).Opening as a PR so the
pull_requesttrigger itself gets validated on a real run before this lands on master.