Skip to content

Standardize API request options#18

Draft
wouter173 wants to merge 1 commit into
mainfrom
feat/issue-17-request-options
Draft

Standardize API request options#18
wouter173 wants to merge 1 commit into
mainfrom
feat/issue-17-request-options

Conversation

@wouter173

Copy link
Copy Markdown
Owner

Summary

  • add typed request options for request bodies, path parameters, and query parameters
  • centralize camelCase to snake_case encoding, including nested Schema.fromJsonString values
  • migrate existing endpoints away from manual encoding and unnecessary Effect generators
  • add focused coverage for body, query, and path encoding

Testing

  • 74 tests pass
  • formatting check passes
  • lint passes
  • diff check passes

Known issue

The repository typecheck still reports the two existing UrlParams.makeUrl errors in api/http-client/logging.ts. No changed file reports a type error.

Closes #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design system around api request options

1 participant