refactor: credential check as ProofRequest method by chipp · Pull Request #411 · worldcoin/walletkit

chipp · 2026-05-18T15:43:25Z

Summary

Moves check_credentials_against_proof_request free function into ProofRequest::check_credentials method (addresses Paolo's review on add credential pre-flight check against proof requests #404)
Converts requests.rs → requests/mod.rs with credential_check submodule
Replaces manual constraint validation with self.0.validate_constraints()? now that world-id-core 0.11.x is available (resolves Dzejkop's TODO)
Adds From<ValidationError> for CredentialConstraintsCheckError
Drops constraint expression tests that duplicate world-id-primitives coverage; retains 6 walletkit-specific tests

Test plan

cargo test -p walletkit-core requests::credential_check
cargo check --all-features

chipp · 2026-05-18T15:43:39Z

refactor: credential check as ProofRequest method #411 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

paolodamico · 2026-05-19T11:27:13Z

+    /// - [`CredentialConstraintsCheckError::Storage`] if the credential store query fails.
+    /// - [`CredentialConstraintsCheckError::ConstraintTooDeep`] if the constraint tree exceeds depth 2.
+    /// - [`CredentialConstraintsCheckError::ConstraintTooLarge`] if the constraint tree exceeds the node limit.
+    pub fn check_credentials(


I think this is implementing duplicate logic from https://github.com/worldcoin/world-id-protocol/blob/ada9887a40255ce7e8576cbca4e0442c049d887d/crates/primitives/src/request/mod.rs#L374. is this performing any additional action from just exposing that method to foreign code?

I will reuse this method for constraints evaluation, thanks for sharing.

however, check_credentials applies time constraints per item and returns per-item diagnostics for UI before triggering ZK proof generation.
there are two options (or more, idk) here:
— keep in walletkit: time checks stay here, can't reuse protocol's since they're buried in circuit input validation.
— add to protocol primitives: expose time checks as a reusable method, walletkit just maps storage records → protocol types.

- move check_credentials_against_proof_request into ProofRequest::check_credentials under requests/credential_check.rs - replace manual constraint depth/node checks with validate_constraints() - drop tests that duplicate world-id-primitives coverage

chipp marked this pull request as ready for review May 18, 2026 15:47

chipp requested a review from paolodamico May 18, 2026 15:47

chipp mentioned this pull request May 18, 2026

add credential pre-flight check against proof requests #404

Merged