Skip to content

feat: add WIP-103 proof verification to CLI#403

Open
paolodamico wants to merge 2 commits into
mainfrom
cli-wip-103
Open

feat: add WIP-103 proof verification to CLI#403
paolodamico wants to merge 2 commits into
mainfrom
cli-wip-103

Conversation

@paolodamico
Copy link
Copy Markdown
Contributor

@paolodamico paolodamico commented May 8, 2026

Adds WIP-103 proof verification to the CLI.


Note

Medium Risk
Adds a new CLI path for decoding and verifying ownership proofs (base64url+CBOR) and introduces new crypto dependencies, which could affect verification correctness and error handling. Also tweaks dev build profiles for ProveKit crates, which may change debug-time behavior.

Overview
Adds a new walletkit proof verify-ownership subcommand that reads a base64url-encoded CBOR OwnershipProof, parses --nonce/--sub field elements, runs verify_ownership_proof, and reports results in both human and JSON modes (exiting non-zero on failure).

Updates CLI output to use TTY-aware colored PASS/FAIL labels via new helpers in output.rs, and extends dependencies/build settings (adds world-id-proof + ciborium; pins ProveKit dev debug-assertions=false to avoid non-serialized debug-only proof fields; pulls in provekit-verifier in the lockfile).

Reviewed by Cursor Bugbot for commit 457a7e0. Bugbot is set up for automated code reviews on this repo. Configure here.

@paolodamico paolodamico requested a review from kilianglas May 8, 2026 23:34
@paolodamico
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant