Skip to content

feat(sdk): expose 4.0 selfie credential#259

Open
Takaros999 wants to merge 1 commit into
mainfrom
takis/face-credential-4-requests
Open

feat(sdk): expose 4.0 selfie credential#259
Takaros999 wants to merge 1 commit into
mainfrom
takis/face-credential-4-requests

Conversation

@Takaros999
Copy link
Copy Markdown
Contributor

@Takaros999 Takaros999 commented May 14, 2026

This PR exposes the World ID 4.0 selfie credential across SDK surfaces.

  • Renames the schema 11 credential identifier from face to selfie in Rust/WASM types.
  • Uses the existing JS CredentialRequest("selfie", ...) path and adds Selfie to the Next.js example dropdown.
  • Exposes the minimal Kotlin and Swift builder constraints(...) path for generated 4.0 constraint nodes.
  • Keeps the broader commented helper APIs commented out.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
idkit-js-example Ready Ready Preview, Comment May 14, 2026 3:18am

Request Review

@Takaros999 Takaros999 force-pushed the takis/face-credential-4-requests branch from 3f6b2cc to 250c22a Compare May 14, 2026 03:15
@Takaros999 Takaros999 changed the title feat(sdk): expose 4.0 face credential feat(sdk): expose 4.0 selfie credential May 14, 2026
@Takaros999 Takaros999 marked this pull request as ready for review May 15, 2026 00:56
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 250c22a9f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust/core/src/types.rs
Comment on lines +32 to 34
/// Selfie credential
Selfie,
/// Passport credential (ICAO 9303 compliant travel document)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve face as an accepted credential alias

Renaming CredentialType::Face to CredentialType::Selfie without a compatibility alias makes previously valid "face" inputs fail deserialization in the WASM/FFI constructors (they deserialize directly into CredentialType). Any existing integration still passing CredentialRequest("face") will now error at request construction time instead of creating a proof request. Keep accepting face as an alias (while emitting selfie) to avoid breaking deployed clients during migration.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant