feat: add user presence flag #230
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Takaros999
force-pushed
the
takis/require-user-presence
branch
from
545def7 to
cc400e7
Compare
Takaros999
force-pushed
the
takis/require-user-presence
branch
from
cc400e7 to
b87a1a8
Compare
Takaros999
force-pushed
the
takis/require-user-presence
branch
from
4450d13 to
521e3ac
Compare
Takaros999
changed the title
Takaros999
requested review from
Guardiola31337,
SeanROlszewski,
andy-t-wang,
murph and
paolodamico
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7aa3766e64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let Some(status) = user_presence_failure_status( | ||
| self.require_user_presence, | ||
| user_presence_completed, | ||
| ) { | ||
| return Ok(status); | ||
| } |
There was a problem hiding this comment.
When require_user_presence is true, this branch returns user_presence_failed before inspecting proof_response.error, which masks real protocol failures (for example invalid_rp_signature or user_rejected) whenever World App returns an error response without user_presence_completed: true. This changes failure semantics for all V2 error payloads under required presence and makes downstream error handling/reporting incorrect; the protocol-level error should be evaluated first, then user-presence enforcement should apply to otherwise successful responses.
Useful? React with 👍 / 👎.
Takaros999
changed the title
2 participants
This PR ...
user_presence_completedon successful resultsuser_presence_failedwhen completion is missing or false