chore(lint): enable @typescript-eslint/consistent-type-imports#30
Open
tupe12334 wants to merge 1 commit into
Open
chore(lint): enable @typescript-eslint/consistent-type-imports#30tupe12334 wants to merge 1 commit into
tupe12334 wants to merge 1 commit into
Conversation
Enforce `import type` for type-only imports. The codebase already follows this convention, so this locks in the pattern and prevents regressions — zero new violations. Type-only imports get fully elided from emitted JS, avoiding accidental runtime imports and improving bundler/isolatedModules behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Summary
Enables the
@typescript-eslint/consistent-type-importsESLint rule (error) forsrc/**/*.{ts,tsx}via a focused override ineslint.config.mjs.The rule requires type-only imports to use the
import type { ... }form, which lets the TypeScript compiler fully elide them from emitted JS — avoiding accidental runtime imports/side effects and improvingisolatedModules/bundler behavior.Changes
eslint.config.mjs: addtypeImportsOverrideenabling the single rule.Verification
pnpm run lint— passes.pnpm run build— passes.No other rules touched. No production code changes.
This pull request was opened by the "Add lint rule → issue + PR (owned repos + my orgs) → Slack" routine of moadim.