-
Notifications
You must be signed in to change notification settings - Fork 9
fix!: require @workos-inc/node >=10.4.0 (eventemitter3 Vite dev crash #106) #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ | |
| "license": "MIT", | ||
| "sideEffects": false, | ||
| "engines": { | ||
| "node": ">=20.0.0" | ||
| "node": ">=22.11.0" | ||
| }, | ||
| "homepage": "https://github.com/workos/authkit-tanstack-start#readme", | ||
| "repository": { | ||
|
|
@@ -70,6 +70,7 @@ | |
| "peerDependencies": { | ||
| "@tanstack/react-router": ">=1.0.0", | ||
| "@tanstack/react-start": ">=1.168.25", | ||
| "@workos-inc/node": ">=10.4.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This package relies on
Prompt To Fix With AIThis is a comment left during a code review.
Path: package.json
Line: 73
Comment:
**Cap WorkOS major**
This package relies on `@workos/authkit-session@0.6.0`, whose peer contract only supports `@workos-inc/node` through major 10. The new `>=10.4.0` peer range also accepts future major versions, so a consumer can install a version that satisfies this package while violating the downstream session package's supported API range, causing peer conflicts or an unsupported dependency pair once v11 exists. Encoding the intended intersection keeps installs on the tested `>=10.4.0 <11` range.
How can I resolve this? If you propose a fix, please make it concise. |
||
| "react": "^18.0 || ^19.0", | ||
| "react-dom": "^18.0 || ^19.0" | ||
| }, | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.