Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"license": "MIT",
"sideEffects": false,
"engines": {
"node": ">=20.0.0"
"node": ">=22.11.0"
},
"homepage": "https://github.com/workos/authkit-tanstack-start#readme",
"repository": {
Expand All @@ -70,6 +70,7 @@
"peerDependencies": {
"@tanstack/react-router": ">=1.0.0",
"@tanstack/react-start": ">=1.168.25",
"@workos-inc/node": ">=10.4.0",
Comment thread
nicknisi marked this conversation as resolved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Cap WorkOS major

This package relies on @workos/authkit-session@0.6.0, whose peer contract only supports @workos-inc/node through major 10. The new >=10.4.0 peer range also accepts future major versions, so a consumer can install a version that satisfies this package while violating the downstream session package's supported API range, causing peer conflicts or an unsupported dependency pair once v11 exists. Encoding the intended intersection keeps installs on the tested >=10.4.0 <11 range.

T-Rex Ran code and verified through T-Rex

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 73

Comment:
**Cap WorkOS major**

This package relies on `@workos/authkit-session@0.6.0`, whose peer contract only supports `@workos-inc/node` through major 10. The new `>=10.4.0` peer range also accepts future major versions, so a consumer can install a version that satisfies this package while violating the downstream session package's supported API range, causing peer conflicts or an unsupported dependency pair once v11 exists. Encoding the intended intersection keeps installs on the tested `>=10.4.0 <11` range.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Devin Fix in Claude Code

"react": "^18.0 || ^19.0",
"react-dom": "^18.0 || ^19.0"
},
Expand Down
24 changes: 10 additions & 14 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading