Conversation
Minimal changes to get the ESPS 6.0 codebase compiling on modern macOS with Apple clang 17 targeting arm64. GUI/X11/audio components are excluded. Build system changes: - SETUP: Add C89 compatibility flags (-std=gnu89, -Wno-implicit-*) for macOS, make XView detection non-fatal, guard macAudio binary copy - COMPILE: Copy other_includes before build, comment out GUI/X11/audio/HP components (libxv, xwaves, image, formsy, ps_ana, gpstohp, etc.) - lib/makefile: Remove xsend.o (X11-dependent) from library objects - ATT/libsig/Makefile: Remove -DFOR_XVIEW to avoid xview.h dependency - sphere2.6 Makefiles: Replace gcc -ansi with gnu89 + warning suppression - lib_header/makefile: Add mkdir -p for esps/waves/ers subdirectories Source code fixes (minimal, compiler-required only): - sphere.h: Guard u_int macro with __APPLE__ to avoid typedef conflict - fixio.c: Add #include <unistd.h> for swab() declaration - vqdesign.c: Add #include <stdlib.h>, fix implicit int declaration - vqencode.c: Add #include <stdlib.h> for exit() declaration - addfeahd.c, btosps.c: Add LINUX_OR_MAC to platform guards for lvalue cast Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add container-based Linux build alongside existing macOS support. 154 CLI utilities compile on Ubuntu 24.04 (GCC 13, arm64/x86_64). Build system changes: - SETUP: Linux section with gnu89 mode, -fcommon, warning suppressions, architecture-agnostic X11 path, circular library dep resolution - COMPILE: cross-platform libexv.a stub for disabled XView - Dockerfile, .dockerignore, Makefile: containerized build via Apple container CLI (same pattern as miniDSP) - README: Linux build instructions and corrected binary counts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make container-test(ApplecontainerCLI)-fno-commondefault, macOSarcompatibilityChanges
-std=gnu89 -fcommon), warning suppressions, arch-agnosticX_LIB, library link order for GNU ld circular dependencieslibexv.astub via dummy object (works on both macOS and Linuxar)container-testtargetTest plan
make container-testbuilds successfully (154 binaries in container)🤖 Generated with Claude Code