feat: Inital implementation of verify_certs#116
Open
johannwagner wants to merge 1 commit into
Open
Conversation
johannwagner
force-pushed
the
feature/verify-certs
branch
from
78b2fb9 to
9fd7de8
Compare
loulecrivain
approved these changes
Apr 29, 2026
Contributor
loulecrivain
left a comment
loulecrivain
left a comment
There was a problem hiding this comment.
no remarks on the code itself, but right now urllib3 is emitting warnings to stderr when verifying certs is deactivated. depending on how you're parsing cosmo output in vicky, may be an issue with JSON mode(?).
warnings.warn(
/home/lou/src/wobcom/cosmo/.venv/lib/python3.12/site-packages/urllib3/connectionpool.py:1097: InsecureRequestWarning: Unverified HTTPS request is being made to host 'netbox.service.wobcom.de'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings
feel free to address it in this PR if thats an issue, otherwise we can leave it as is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the demo rack, it is not easily doable to setup SSL correctly, therefore, we should be able to disable it in Cosmo.