chore: add Makefile-driven dev toolchain - #74
Merged
Conversation
Add a Makefile mirroring the format/lint/test targets used across the sibling repos, wiring up taplo (toml), mdformat+gfm (md), yamlfix (yaml), and typos alongside the existing ruff and ty. .mdformat.toml keeps consecutive ordered-list numbering; _typos.toml allowlists the OctoMap domain terms 'leafs' (upstream API spelling) and 'ot' (full-map file extension).
mdformat adds blank lines after headings in CHANGELOG; yamlfix rewrites the workflow YAML to its canonical style. No behavior change.
Replace the inline ruff/ty/pytest steps with 'make lint' and 'make test' so CI and local development share one source of truth. lint runs once; test keeps the Python 3.10/3.14 matrix.
Owner
Author
Verdict: Two non-blocking observations for your call, neither gating the merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefilewithhelp/setup/format/lint/test/coveragetargets, matching the convention used across the sibling repos so CI and local development share one source of truth.lint/formatnow cover ruff and ty plus taplo (toml), mdformat+mdformat-gfm (md), yamlfix (yaml), and typos;testruns underpytest-xdist..mdformat.tomlkeeps consecutive ordered-list numbering (number = true);_typos.tomlallowlists the OctoMap domain termsleafs(upstream C++ API spelling) andot(the.otfull-map file extension).ci.ymlnow delegates tomake lint(run once) andmake test(kept on the 3.10/3.14 matrix).A few mechanical churn notes for the reviewer:
pyproject.toml(2-space indent, sorted keys/arrays). Large visual diff but idempotent; comments stay attached.CHANGELOG.md;docs/agents/triage-labels.md's hand-aligned table is compacted by mdformat-gfm.Test plan
make lint(ruff, ty, taplo, mdformat, yamlfix, typos all green)make test(40 passed)