feat: add branch details endpoint#30
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for fetching employer branch details (service EX_BASE_02) by introducing a new BusinessBranch model and exposing a corresponding ErganiClient method, with unit tests covering parsing and client behavior.
Changes:
- Introduce
BusinessBranchdataclass with parsing helpers for theEX_BASE_02response shape. - Add
ErganiClient.get_branch_details()to executeEX_BASE_02and parse the JSON response. - Add unit tests validating parsing and the new client method behavior (including 204/No Content).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ergani/models.py |
Adds BusinessBranch model and parsing logic for EX_BASE_02. |
ergani/client.py |
Adds get_branch_details() client method that executes EX_BASE_02. |
tests/test_branch_details.py |
Adds tests for parsing and client integration around branch details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
parisk
requested changes
May 19, 2026
Contributor
parisk
left a comment
parisk
left a comment
There was a problem hiding this comment.
I have a non blocking comment, but requesting changes to ensure we review copilot's comments.
Co-authored-by: Paris Kasidiaris <paris@withlogic.co>
Deploying ergani with
|
| Latest commit: |
0342699
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a29047c.ergani.pages.dev |
| Branch Preview URL: | https://feature-ex-base-02-branch-de.ergani.pages.dev |
…feature/ex-base-02-branch-details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.