feat: add employer details endpoint#29
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class support for retrieving and parsing employer details from Ergani’s EX_BASE_01 service, plus accompanying unit tests.
Changes:
- Introduces an
EmployerDetailsmodel with parsing helpers for theEX_BASE_01payload shape. - Adds
ErganiClient.get_employer_details()which executesEX_BASE_01and returns parsed employer details. - Adds a dedicated test module covering parsing behavior and the client integration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ergani/models.py |
Adds EmployerDetails dataclass, parsing helpers, and parse_employer_details. |
ergani/client.py |
Adds get_employer_details() and a small _request refactor for endpoint normalization. |
tests/test_employer_details.py |
Adds unit tests for EmployerDetails parsing and the client method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.