Fix tuple syntax when using key sequence in distinct()#804
Open
Kirkman wants to merge 1 commit intowireservice:masterfrom
Open
Fix tuple syntax when using key sequence in distinct()#804Kirkman wants to merge 1 commit intowireservice:masterfrom
Kirkman wants to merge 1 commit intowireservice:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed in the past that
Table.distinct()does not deduplicate when the key is a list or sequence of column names.Code like this (wrongly) results in no rows being dropped ...
table = table.distinct(['PARCELID', 'SITEADDR'])... whereas code like this does successfully drop duplicate rows:
table = table.distinct(lambda row: str(row['PARCELID']) + str(row['SITEADDR']))I believe the cause is line 31 of
agate/table/distinct.py, which constructs the row's key for de-duplicating:k = (row[j] for j in key)I think the parentheses here create are creating a generator expression, not a tuple.
kis always unique, and no de-duplication ever occurs.My suggested fix is to wrap it with
tuple(...):k = tuple(row[j] for j in key)