Skip to content

feat: adminless events (WPB-25284) - #4352

Open
sbakhtiarov wants to merge 2 commits into
developfrom
feat/adminless-events
Open

feat: adminless events (WPB-25284)#4352
sbakhtiarov wants to merge 2 commits into
developfrom
feat/adminless-events

Conversation

@sbakhtiarov

@sbakhtiarov sbakhtiarov commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25284

https://wearezeta.atlassian.net/browse/WPB-25284

What's new in this PR?

Adding support for new events for "Prevent Adminless groups" feature.

conversation.system.member-update and conversation.system.delete
These are new version of conversation.member-update and conversation.delete events which could be send by BE without sender user Id.

conversation.adminless-reminder / conversation.system.adminless-reminder
New event for notifying conversation users that conversation will be deleted by BE at given time.
This event adds new system message to the conversation.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Test Results

0 tests   - 6 107   0 ✅  - 5 964   0s ⏱️ - 4m 23s
0 suites  -   914   0 💤  -   143 
0 files    -   914   0 ❌ ±    0 

Results for commit 7056798. ± Comparison against base commit 45e3bc2.

♻️ This comment has been updated with latest results.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.01887% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.28%. Comparing base (45e3bc2) to head (7056798).

Files with missing lines Patch % Lines
...in/com/wire/kalium/logic/data/event/EventMapper.kt 75.86% 9 Missing and 5 partials ⚠️
...tlin/com/wire/kalium/logic/data/message/Message.kt 0.00% 3 Missing ⚠️
.../api/authenticated/notification/EventContentDTO.kt 92.10% 3 Missing ⚠️
...re/kalium/persistence/dao/message/MessageMapper.kt 60.00% 2 Missing ⚠️
...kalium/logic/data/message/PersistMessageUseCase.kt 0.00% 2 Missing ⚠️
...m/wire/kalium/logic/data/message/MessageContent.kt 66.66% 1 Missing ⚠️
.../persistence/dao/message/MessageInsertExtension.kt 83.33% 0 Missing and 1 partial ⚠️
...om/wire/kalium/logic/data/message/MessageMapper.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #4352      +/-   ##
=============================================
+ Coverage      61.22%   61.28%   +0.06%     
- Complexity      4223     4237      +14     
=============================================
  Files           2195     2196       +1     
  Lines          71257    71425     +168     
  Branches        7195     7216      +21     
=============================================
+ Hits           43624    43772     +148     
- Misses         24793    24803      +10     
- Partials        2840     2850      +10     
Files with missing lines Coverage Δ
...re/kalium/persistence/dao/message/MessageEntity.kt 82.35% <100.00%> (+0.12%) ⬆️
...n/kotlin/com/wire/kalium/logic/data/event/Event.kt 76.10% <100.00%> (+0.58%) ⬆️
...m/logic/sync/receiver/ConversationEventReceiver.kt 83.07% <100.00%> (+1.10%) ⬆️
...ersation/DeleteConversationReminderEventHandler.kt 100.00% <100.00%> (ø)
...er/conversation/DeletedConversationEventHandler.kt 100.00% <100.00%> (ø)
...m/wire/kalium/logic/data/message/MessageContent.kt 47.03% <66.66%> (+0.20%) ⬆️
.../persistence/dao/message/MessageInsertExtension.kt 84.53% <83.33%> (+0.24%) ⬆️
...om/wire/kalium/logic/data/message/MessageMapper.kt 18.03% <66.66%> (+0.63%) ⬆️
...re/kalium/persistence/dao/message/MessageMapper.kt 50.38% <60.00%> (+0.09%) ⬆️
...kalium/logic/data/message/PersistMessageUseCase.kt 19.23% <0.00%> (-0.25%) ⬇️
... and 3 more

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e3bc2...7056798. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch${GITHUB_HEAD_REF}
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
589.70 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
476,401.13 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
96,127.93 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
90,793.37 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.localMarkAsReadBenchmark📈 view plot
⚠️ NO THRESHOLD
4,954.95 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
21,926.28 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
10,723.75 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,079,521.02 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
20,348.35 µs
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants