fix: recover from prolonged MLS message buffering (WPB-26421) - #4341
Draft
sbakhtiarov wants to merge 2 commits into
Draft
fix: recover from prolonged MLS message buffering (WPB-26421)#4341sbakhtiarov wants to merge 2 commits into
sbakhtiarov wants to merge 2 commits into
Conversation
Contributor
Test Results0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s Results for commit 2dccb3a. ± Comparison against base commit a0d6a8f5. ♻️ This comment has been updated with latest results. |
sbakhtiarov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26421
https://wearezeta.atlassian.net/browse/WPB-26421
What is new in this PR?
Issue
If a commit is missed, CoreCrypto can keep buffering later MLS messages indefinitely and the conversation does not recover.
Solution
BufferedMLSMessageRecoveryTracker, scoped by conversation and subconversation, to track the timestamp span of buffered events in memory.Dependency
This is stacked on #4316, which surfaces buffered CoreCrypto failures to the event-processing layer. After #4316 merges, this branch will be rebased onto
developand the PR base will be retargeted.