refactor(time): reduce internal date conversions PR 6 [WPB-10090] - #4339
Open
MohamadJaara wants to merge 4 commits into
Open
refactor(time): reduce internal date conversions PR 6 [WPB-10090]#4339MohamadJaara wants to merge 4 commits into
MohamadJaara wants to merge 4 commits into
Conversation
Contributor
MohamadJaara
marked this pull request as ready for review
July 24, 2026 16:30
saleniuk
approved these changes
Jul 27, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4339 +/- ##
=============================================
+ Coverage 61.11% 61.23% +0.11%
- Complexity 4238 4244 +6
=============================================
Files 2200 2200
Lines 78411 71550 -6861
Branches 7223 7225 +2
=============================================
- Hits 47920 43811 -4109
+ Misses 27638 24877 -2761
- Partials 2853 2862 +9
... and 1098 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
MohamadJaara
force-pushed
the
mo/improve-internal-time-handling
branch
from
July 30, 2026 22:20
d3abd85 to
0fdb3a7
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-10090
Small cleanup to keep a few more timestamps typed as
Instantinternally and avoid repeated formatting/parsing.Instantfor conversation status refs, server time, and subconversation epoch timeDateTimeFormatterpathNo DB migration is needed. Callers passing a custom conversation status timestamp should now pass an
Instant.Stacked on #4338.
Checks: Logic and Persistence JVM tests, Detekt, ABI check, and the Android
core:utilcompile.