Skip to content

[codex] log only configured XFCC header#648

Merged
winhowes merged 1 commit into
mainfrom
codex/log-only-xfcc-header
May 8, 2026
Merged

[codex] log only configured XFCC header#648
winhowes merged 1 commit into
mainfrom
codex/log-only-xfcc-header

Conversation

@winhowes
Copy link
Copy Markdown
Owner

@winhowes winhowes commented May 8, 2026

Summary

  • Restrict envoy_xfcc auth failure logs to the configured XFCC header values instead of cloning the full request header map.
  • Keep reason and configured_header in the structured log payload.
  • Update the existing XFCC logging test to assert unrelated request headers are omitted.

Impact

Auth failure diagnostics still include the XFCC evidence needed for debugging, but unrelated headers such as tokens, cookies, or debug headers are not logged by this plugin failure path.

Validation

  • go test ./app/auth ./app/auth/plugins/envoy_xfcc -coverprofile=/tmp/xfcc-only.cover
    • total: 100.0% statements
  • go test ./app/auth ./app/auth/plugins/envoy_xfcc -count=5
  • go test ./... -run '^$' -count=1
  • git diff --check

@winhowes winhowes marked this pull request as ready for review May 8, 2026 19:11
@winhowes winhowes merged commit 9db7efc into main May 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant