fix(mcp): emit all three tool annotation hints for ChatGPT Apps - #141
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
OpenAI's ChatGPT Apps submission requires readOnlyHint, openWorldHint, and destructiveHint to be present (true or false) on every tool. Two gaps: 1. The 4 read-only tools omitted destructiveHint — now set explicitly to false via the *bool field. 2. save_recipe's readOnlyHint:false was dropped: the Go SDK marshals ToolAnnotations.ReadOnlyHint with omitempty, so false never reaches the wire. Adds an ensureReadOnlyHint middleware that backfills the spec-default readOnlyHint:false into any tools/list annotations object missing it. Only tools/list responses are buffered/rewritten; streaming tool calls pass through untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
windoze95
force-pushed
the
fix/mcp-tool-annotation-hints
branch
from
July 8, 2026 03:32
3570f73 to
8ac9fda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI's ChatGPT Apps submission requires
readOnlyHint,openWorldHint, anddestructiveHintpresent on every tool.destructiveHint:falseto the 4 read-only tools (*bool).ensureReadOnlyHintmiddleware backfillingreadOnlyHint:falseontools/list— the Go SDK drops it viaomitempty. Streaming tool calls pass through untouched.Full suite + new middleware tests (JSON, SSE, pass-through) green.
🤖 Generated with Claude Code