feat: Add ModelsLab TTS engine support#66
Merged
Conversation
- Added ModelsLabClient class in tts_wrapper/engines/modelslab/ - Added SSML handler (strips tags since no native SSML support) - Updated engines/__init__.py to export ModelsLabClient - Updated pyproject.toml with modelslab optional dependency - Added tests/test_tts_engines.py integration Features: - Multiple voice options (madison, tara, leah, jess, mia, zoe, leo, dan, zac) - Language support - Speed control - Async polling for audio generation - Full implementation of AbstractTTS interface
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4966439d8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- P1: Fix ValueError when rate property is empty string (base class default). Use truthy check instead of is-not-None so float() is only called with an actual numeric string value. - P2: Fix SSML stripping being a no-op. Use re.sub to actually remove XML/SSML tags before sending plain text to ModelsLab API.
Owner
|
Going to merge this. Failiures aer due to keys not in the fork.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds ModelsLab as a new TTS engine to tts-wrapper.
Changes
Features
Example Usage
Motivation
ModelsLab provides affordable TTS APIs with multiple voice options. Adding support for it gives users another cost-effective option alongside existing engines like ElevenLabs, OpenAI, and PlayHT.
Get your API key at: https://modelslab.com/dashboard/api-keys