chore(ci): retire security-snyk.yml and merge duplicate security-codeql.yml - #134
Open
williaby wants to merge 1 commit into
Open
chore(ci): retire security-snyk.yml and merge duplicate security-codeql.yml#134williaby wants to merge 1 commit into
williaby wants to merge 1 commit into
Conversation
williaby
enabled auto-merge (squash)
September 3, 2026 12:42
williaby
force-pushed
the
chore/retire-snyk-merge-codeql
branch
from
September 3, 2026 12:56
3d34bfa to
9e0955c
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
It leaves broken/stale repository documentation (e.g., README badge and UML diagram still referencing the removed Snyk workflow) and the “duplicate CodeQL” rationale doesn’t match the current repo CodeQL coverage.
Pull request overview
This PR cleans up GitHub Actions security workflows by removing two workflows that are no longer desired (Snyk due to account limitations, and a custom CodeQL workflow believed to be redundant) to reduce CI maintenance overhead.
Changes:
- Removed
.github/workflows/security-snyk.yml(Snyk-based security scanning). - Removed
.github/workflows/security-codeql.yml(custom multi-language CodeQL scanning workflow).
File summaries
| File | Description |
|---|---|
| .github/workflows/security-snyk.yml | Deletes the Snyk security workflow from the CI pipeline. |
| .github/workflows/security-codeql.yml | Deletes a CodeQL workflow that previously scanned multiple languages (python, javascript-typescript, actions). |
Review details
Suppressed comments (2)
.github/workflows/security-snyk.yml:1
- Removing this workflow will leave stale references in repo docs: README has a Security Workflow Status badge pointing at actions/workflows/security-snyk.yml, and docs/uml/workflows-overview.puml lists security-snyk.yml. After this deletion those links/diagrams will be broken; please update/remove those references in the same PR.
.github/workflows/security-codeql.yml:1 - PR description says security-codeql.yml is a duplicate of the repo’s standard codeql.yml, but codeql.yml only runs CodeQL for Python whereas this workflow also analyzed javascript-typescript and actions. Deleting it reduces CodeQL coverage (including GitHub Actions workflow scanning); please either update codeql.yml to cover the removed languages or clarify in the PR description that this is an intentional reduction.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
auto-merge was automatically disabled
September 3, 2026 20:17
Pull request was closed
williaby
enabled auto-merge (squash)
September 3, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two security workflow cleanups:
security-snyk.yml: removed -- Snyk requires paid account; free tier is insufficient for SAST/container scanningsecurity-codeql.yml: removed -- duplicate of standardcodeql.ymlalready present in repoSummary by CodeRabbit