passes timestampsInSnapshots to Firestore.settings() to prevent warning#54
Open
kitfit-dave wants to merge 2 commits into
Open
passes timestampsInSnapshots to Firestore.settings() to prevent warning#54kitfit-dave wants to merge 2 commits into
kitfit-dave wants to merge 2 commits into
Conversation
also, not default app, need to use the app instance to call settings
Author
|
Oh yeah, so, would have to actually support the Timestamp type as well (if there are any in the firestore that you want to backup and restore) |
|
This PR solves a bug where the timestamp type will always be the current date. |
Author
|
Does it? Woohoo. :). I don’t think Timestamp type is properly supported yet anyway, it doesn’t not get detected like other types (or the old date type), and is just treated like an object. It gets backed up, but I’ve not checked what it restores as (I don’t use any timestamps in any collections worth backing up). |
|
Thank you for your reply. Yes, it is a bug that occurs when restore. This backup.json {
"creationDate": {
"type": "timestamp",
"value": "2018-11-22T02:42:13.058Z"
},
"id": {
"type": "string",
"value": "Yy4vNitGnrCRJR849EWW"
},
... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes /issues/38