Skip to content

passes timestampsInSnapshots to Firestore.settings() to prevent warning#54

Open
kitfit-dave wants to merge 2 commits into
willhlaw:masterfrom
kitfit-dave:master
Open

passes timestampsInSnapshots to Firestore.settings() to prevent warning#54
kitfit-dave wants to merge 2 commits into
willhlaw:masterfrom
kitfit-dave:master

Conversation

@kitfit-dave

@kitfit-dave kitfit-dave commented Nov 21, 2018

Copy link
Copy Markdown

Fixes /issues/38

@kitfit-dave

Copy link
Copy Markdown
Author

Oh yeah, so, would have to actually support the Timestamp type as well (if there are any in the firestore that you want to backup and restore)

@wata

wata commented Nov 26, 2018

Copy link
Copy Markdown

This PR solves a bug where the timestamp type will always be the current date.

@kitfit-dave

Copy link
Copy Markdown
Author

Does it? Woohoo. :).

I don’t think Timestamp type is properly supported yet anyway, it doesn’t not get detected like other types (or the old date type), and is just treated like an object. It gets backed up, but I’ve not checked what it restores as (I don’t use any timestamps in any collections worth backing up).

@wata

wata commented Nov 27, 2018

Copy link
Copy Markdown

Thank you for your reply.

Yes, it is a bug that occurs when restore.

This creationDate will change to the current date on firestore.

backup.json

{
  "creationDate": {
    "type": "timestamp",
    "value": "2018-11-22T02:42:13.058Z"
  },
  "id": {
    "type": "string",
    "value": "Yy4vNitGnrCRJR849EWW"
  },
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants