fix(LoongArch64/RV64): allow empty sequence for merge_eflags#1996
Merged
Conversation
marxin
force-pushed
the
fix-loongarch64-empty-eflags
branch
from
a3bb5c8 to
14778ca
Compare
marxin
changed the title
marxin
force-pushed
the
fix-loongarch64-empty-eflags
branch
from
14778ca to
242e5db
Compare
Collaborator
Author
|
Good, I've just verified we behave the same as Mold and LLD on the LoongArch64 platform - 2 Mold external tests are fixed with that. |
davidlattimore
approved these changes
May 30, 2026
Member
davidlattimore
left a comment
davidlattimore
left a comment
There was a problem hiding this comment.
This doesn't necessitate an update to the mold skip tests list? Otherwise, looks good.
Collaborator
Author
|
These tests were not excluded in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that while debugging the Mold external tests on LoongArch64 (and RV64) - for an empty shared library, we can have none eflags to be merged and so we should allow empty sequence and build
object::elf::FileFlags::(0).