Fix RSSI SBS output: buffer size and log10 clamp#136
Merged
Conversation
Two hardening fixes for the --devel=sbs_rssi extension: 1. Increase prepareWrite allocation from 200 to 250 bytes when sbs_rssi is enabled. The original 200-byte buffer was sized before field 23 was added; RSSI appends up to ~7 bytes (e.g. ",-48.1") and the extra headroom prevents any possibility of overflow on a maximally populated SBS line. 2. Add fmax(signalLevel, 1e-10) clamp before log10(). signalLevel is bounded [0,1] by unsigned char arithmetic and the > 0 guard already prevents log10(0), but the explicit clamp documents the invariant and protects against subnormal edge cases if the source path ever changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
wiedehopf
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two hardening fixes for the --devel=sbs_rssi extension:
Increase prepareWrite allocation from 200 to 250 bytes when sbs_rssi is enabled. The original 200-byte buffer was sized before field 23 was added; RSSI appends up to ~7 bytes (e.g. ",-48.1") and the extra headroom prevents any possibility of overflow on a maximally populated SBS line.
Add fmax(signalLevel, 1e-10) clamp before log10(). signalLevel is bounded [0,1] by unsigned char arithmetic and the > 0 guard already prevents log10(0), but the explicit clamp documents the invariant and protects against subnormal edge cases if the source path ever changes.