Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves directory creation logic by using the exist_ok=True parameter in os.makedirs() instead of manually checking if the directory exists first. This simplifies the code and makes it more robust against race conditions.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| filter_path = os.path.join(_DEFAULT_PATH, f"{name}.bloom") | ||
| if not os.path.exists(_DEFAULT_PATH): | ||
| os.makedirs(_DEFAULT_PATH) | ||
| os.makedirs(_DEFAULT_PATH, exist_ok=True) |
There was a problem hiding this comment.
This change fixes a potential race condition where the directory could be created by another process between the existence check and the makedirs call. The exist_ok=True parameter is the correct approach.
Jgmedina95
approved these changes
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30