Allow blockSpacing to do what it suggests it does - #3
Open
Rubio9 wants to merge 1 commit into
Open
Conversation
The existing code reserved the height of the icon (iconW) for the height of an objective title, when this is usually much too much. This correctly calculates the height of a Row to be the max of the total text size or the height of the icon, which better fits how a Row is actually laid out. Also shuffled around where SetWidth gets called to simplify the code and make it handle width changes more cleanly.
Owner
|
Thanks for this.. My workload is massive right now, so I appreciate any help I can get. Feel free to tweak anything, or add a new feature that is within scope. PR's are def welcome. I just pushed a huge bug fix, so next patch I will get this merged. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Love the addon! Just found it recently and it's great!
I hope you accept user PRs to improve it. I notice the gap between objectives is massive, and reducing blockSpacing to 0 does not let it go below a too-large-for-my-liking floor. This fixes that.
The existing code reserved the height of the icon (iconW) for the height of an objective title, when this is usually much too much. This correctly calculates the height of a Row to be the max of the total text size or the height of the icon, which better fits how a Row is actually laid out.
Also shuffled around where SetWidth gets called to simplify the code and make it handle width changes more cleanly.