HTML insertion positional methods#12528
Open
noamr wants to merge 10 commits into
Open
Conversation
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
Jun 11, 2026
Ensure a consistent order of operations for all the new HTML insertion methods (appendHTML, prependHTML, beforeHTML, afterHTML, replaceWithHTML) - The trusted types createHTML test should always come first - ChildNode methods should then ensure the parent can accept HTML, or throw - Correctly handle <template> in all the methods (e.g. `template.appendHTML`, `template.content.beforeHTML`) - Assert some edge cases in WPT (e.g. trusted types moves nodes around) See spec PR: whatwg/html#12528 Bug: 491743369 Change-Id: I5e587ae12faad3d706e2d993bd1aa88500b3e6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7915261 Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645229}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 11, 2026
Ensure a consistent order of operations for all the new HTML insertion methods (appendHTML, prependHTML, beforeHTML, afterHTML, replaceWithHTML) - The trusted types createHTML test should always come first - ChildNode methods should then ensure the parent can accept HTML, or throw - Correctly handle <template> in all the methods (e.g. `template.appendHTML`, `template.content.beforeHTML`) - Assert some edge cases in WPT (e.g. trusted types moves nodes around) See spec PR: whatwg/html#12528 Bug: 491743369 Change-Id: I5e587ae12faad3d706e2d993bd1aa88500b3e6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7915261 Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645229}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 11, 2026
Ensure a consistent order of operations for all the new HTML insertion methods (appendHTML, prependHTML, beforeHTML, afterHTML, replaceWithHTML) - The trusted types createHTML test should always come first - ChildNode methods should then ensure the parent can accept HTML, or throw - Correctly handle <template> in all the methods (e.g. `template.appendHTML`, `template.content.beforeHTML`) - Assert some edge cases in WPT (e.g. trusted types moves nodes around) See spec PR: whatwg/html#12528 Bug: 491743369 Change-Id: I5e587ae12faad3d706e2d993bd1aa88500b3e6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7915261 Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645229}
Contributor
Author
|
This should be ready for review (and for additional implementer support) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
appendHTML,prependHTML,beforeHTML,afterHTML, andreplaceWithHTML, alongside their*Unsafevariants.Use 3 helper algorithms for HTML insertion (pre-insert/replace/set), and call those from the appropriate web-exposed method.
ChildNodemethods fail silently when the child has no parent, like their equivalent DOM methods,and fails with a
HierarchyRequestErrorfor an invalid parent.Closes #10122
(See WHATWG Working Mode: Changes for more details.)
/dynamic-markup-insertion.html ( diff )