Make muted content attribute affect muted IDL attribute only once#12473
Make muted content attribute affect muted IDL attribute only once#12473foolip wants to merge 6 commits into
Conversation
|
What do implementations do today? I'm pretty sure WebKit doesn't have a "set once" special case. |
|
Chromium reacts to Gecko seems to look at the WebKit has a tri-state optional bool |
|
For Gecko, the |
|
I see, perhaps observing the That would require changing the |
The purpose of this is to limit the cases where the muted IDL attribute can change without a volumechange event firing. The notion that user agents may remember volume and muted is removed as it would require additional muted states to handle correctly, but could be reinstated if there is implementer interest.
|
@annevk that works for me, I've updated this PR and tests in https://crrev.com/c/7857861 to match. |
annevk
left a comment
There was a problem hiding this comment.
What about the WebKit case of taking the muted content attribute into account when loading a new media resource?
The purpose of this is to limit the cases where the muted IDL attribute
can change without a volumechange event firing.
The notion that user agents may remember volume and muted is removed as
it would require additional muted states to handle correctly, but could
be reinstated if there is implementer interest.
(See WHATWG Working Mode: Changes for more details.)
/media.html ( diff )