Use cached select in selectedness setting algorithm#12083
Closed
josepharhar wants to merge 2 commits into
Closed
Conversation
In order to make the selectedness setting algorithm match implementations, this PR makes the selectedness setting algorithm avoid changing the selectedness of option elements which haven't ran their insertion steps yet by checking whether the options have their cached nearest ancestor select element assigned yet or not. This was discussed here: whatwg#11825
6 tasks
Contributor
Author
I listed some different ways we can proceed here: #11890 (comment) |
Member
|
Is this sufficiently tested by web-platform-tests/wpt#55647 ? |
Contributor
Author
|
I removed the code which does this in chromium in order to find tests which would fail, and I found that html/semantics/forms/the-select-element/inserted-or-removed.html would fail without this logic, specifically with this failure: I'll add this test to the OP |
Contributor
Author
|
We also have an internal test which would fail without this, which I could move to WPT: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/forms/select/multiple-selected-options-innerHTML.html |
Contributor
Author
|
This change is being included in this PR: #12263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make the selectedness setting algorithm match implementations, this PR makes the selectedness setting algorithm avoid changing the selectedness of option elements which haven't ran their insertion steps yet by checking whether the options have their cached nearest ancestor select element assigned yet or not.
This was discussed here: #11825
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )