Add TAO destination check for navigation redirect chains#1931
Add TAO destination check for navigation redirect chains#1931yoavweiss wants to merge 4 commits into
Conversation
|
Chrome team is supportive. |
noamr
left a comment
There was a problem hiding this comment.
Wouldn't it be simpler to keep a list of TAO value sets and iterate over them when computing the "navigation TAO check"?
@annevk made a similar comment earlier on. What we can do is something like:
I don't know that it's simpler (and it seems like we'd be copying more values around between redirect responses), but happy to move to that model if that's simpler/easier |
It's simpler to read (IMO) and potentially cleaner impl wise as there is no set manipulation as you go along and it's not a dedup check for each redirect. |
As part of the WebPerfWG discussion on re-exposing redirectCount for opted-in cross-origin redirects, we discussed the fact that TAO currently only opts-in "backwards" in terms of origins, and doesn't constitute an opt-in to the destination origin, which is the appropriate opt-in for navigations (contrary to subresources).
This PR adds the mechanisms that can enable such "forward" opt-in, and can enable a response to a redirect chain to know that the redirect chain opted in to expose the redirects to its origin.
Once this lands, we'd use the relevant algorithms in the related HTML PR.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff