Support double progression: gate on top of range and require all sets - #2494
Open
aadishsanghvi wants to merge 1 commit into
Open
Support double progression: gate on top of range and require all sets#2494aadishsanghvi wants to merge 1 commit into
aadishsanghvi wants to merge 1 commit into
Conversation
- Add max_repetitions and max_weight requirement rules to gate against the top of prescribed ranges - Add all_sets flag to ConfigRequirements requiring all prescribed sets to qualify - Extend API validators to check all_sets boolean and reject unknown requirement keys - Add regression and lifecycle tests in test_slot_entry, test_change_config_model, and test_api_validators - Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Support classic double progression in the progression requirements engine:
max_repetitionsandmax_weightrules: Read the same log field as their base rule (repetitions,weight) but gate against the top (ceiling) of the prescribed range (states['maxrepetitions']/states['maxweight']) rather than the bottom.all_setsboolean flag: Whentrue, requires at least the prescribed number of sets to be logged and every logged set to satisfy all rules (rather than a single qualifying set being sufficient).all_setsis boolean and rejects unknown keys in the requirements dictionary.max_repetitions,max_weight, under-logging, empty logs, partial qualification, extra sets, full double progression lifecycles, and API validation.Related Issue(s)
Closes #2480
Please check that the PR fulfills these requirements
ruff format && isort .)CHANGELOG.md