fix: add request timeout to paginated fetch helpers - #2477
Open
bunlongheng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
get_all_paginated()andget_paginated()inwger/utils/requests.pycallrequests.get()without atimeout. These two helpers back most of the remote-sync code paths (sync_exercises,sync_languages,sync_licenses,sync_categories,sync_muscles,sync_equipment,handle_deleted_entries,download_exercise_images,download_exercise_videos,download_ingredient_images,sync_ingredients, ...).Why it matters
Without a timeout,
requestsblocks indefinitely when a remote server accepts the connection but never sends a response (a stalled or misbehaving upstream, a hung reverse proxy, a slow-loris style peer). The affected calls run both from management commands and from celery tasks (e.g.fetch_all_ingredient_images_task->download_ingredient_images). A single hung request pins the worker/process forever - it never returns and never raises, so theautoretry_for=(requests.exceptions.RequestException, ...)handling on the surrounding tasks can never kick in either.This is the same defensive pattern the codebase already applies at newer call sites, which pass explicit timeouts (
requests.get(..., timeout=30)insync_ingredients,timeout=(10, 60)indownload_ingredient_dump). These two central helpers were simply missed.Fix
Add a module-level
DEFAULT_REQUEST_TIMEOUT = (10, 60)(connect, read) constant and pass it to bothrequests.get()calls. The tuple form matches the existing style innutrition/sync.py. No signature or behavior change for successful responses.Test
sync_exercises/sync_ingredientsagainst a reachable remote continue to work unchanged.firewall DROPon an open port); the call now raisesrequests.exceptions.ReadTimeoutafter 60s instead of hanging forever, allowing the caller's retry/error handling to run.