Add support for writing atID, plID and cmID atoms#83
Open
jornane wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for writing the Artist ID, Playlist ID and Composer ID atoms.
Originally, I just copied the code already existing for the Content ID atom (cnID), which worked fine except for Playlist ID. Upon examining a file purchased from iTunes, it seems that this atom is longer, which was not supported by the code, so I added support for that as well.
I'm not sure why plID is different from the others;
These byte sequences were obtained from a purchased file:
Note byte[3], which is 0x20 for plID and 0x1c for cnID.