test(llm-coverage): fix and unskip the backup-judge test (#48)#53
Open
serkancakmakk wants to merge 1 commit into
Open
test(llm-coverage): fix and unskip the backup-judge test (#48)#53serkancakmakk wants to merge 1 commit into
serkancakmakk wants to merge 1 commit into
Conversation
The "should use backup judge when one primary judge fails" test was .skipped with stale expectations written for an older DEFAULT_JUDGES set (qwen / gpt-oss / glm). Rewrite it against the current DEFAULT_JUDGES (gemini-2.5-flash, gpt-4.1-mini, claude-haiku-4.5): - Fail one primary (gpt-4.1-mini) so the backup judge is activated. - Match the backup by its id (backup-claude-4-5-haiku) since it shares a model with a primary judge. - Average the two surviving primaries plus the backup ((0.8+0.6+0.4)/3). Un-skipped and passing; the full llm-coverage-evaluator suite is green (39 passed, 0 skipped). Closes weval-org#48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #48.
The
"should use backup judge when one primary judge fails"test insrc/cli/evaluators/__tests__/llm-coverage-evaluator.test.tswas.skipped because its expectations were stale — they were written for an olderDEFAULT_JUDGESset (qwen/gpt-oss/glm) that no longer exists. This rewrites the test against the currentDEFAULT_JUDGESand un-skips it.What changed
Current
DEFAULT_JUDGES(allholistic):google/gemini-2.5-flash,openai/gpt-4.1-mini,anthropic/claude-haiku-4.5; backup judge:anthropic/claude-haiku-4.5(idbackup-claude-4-5-haiku).The rewritten test:
gpt-4.1-mini) and lets the other two succeed, sosuccessfulJudgements < totalJudgesAttemptedtriggers the backup phase.backup-claude-4-5-haiku) first, since it shares its model with a primary judge and couldn't otherwise be distinguished in the mock.(0.8 + 0.6 + 0.4) / 3 = 0.6, matching the source'savgScore.toFixed(2)consensus logic.The assertions still verify the meaningful behavior — backup activation (
DEFAULT_JUDGES.length + 1judge calls), the consensus score, the"NOTE: Backup judge was used to supplement failed primary judges."reflection, and no error — so it reflects intended behavior rather than being forced to pass.Acceptance criteria
llm-coverage-evaluatorsuite greenVerification
No
.skipremains in the file.