[FEATURE]: Updates to React 19 - #120
Merged
Merged
Conversation
andrewrubin
reviewed
Aug 24, 2026
NicholasLancey
marked this pull request as ready for review
August 24, 2026 22:45
andrewrubin
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whilst trying to add the
loadingprop to the<video />element I was getting Typescript errors warning me thatloadingisn't a valid attribute of the element. This is because React 18's typescript definitions are outdated. Upgrading to React 19 is the simplest way of getting around this.Once this is approved and merged, I'll create another PR handling the loading functionality.