Move verification_tests from src/ to tests/ as integration test#56
Merged
Merged
Conversation
- Moved src/launch/verification_tests.rs to tests/launch_verification_tests.rs (was missing #[cfg(test)] guard, making it unsuitable as inline unit test) - Removed dead mod verification_tests declaration from src/launch/mod.rs - All other #[cfg(test)] unit tests in src/ remain unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moved
src/launch/verification_tests.rstotests/launch_verification_tests.rs.Problem
The original
src/launch/verification_tests.rsfile was missing a#[cfg(test)]guard at the top. While the parent module (src/launch/mod.rs) correctly wrappedmod verification_testsin#[cfg(test)], the file itself should be self-contained to avoid accidental compilation of test-only code into production binaries.Changes
src/launch/verification_tests.rs→tests/launch_verification_tests.rstests/are excluded from normal compilation automatically)crate::imports work correctly since integration tests depend on the library cratemod verification_testsdeclaration and its#[cfg(test)]guard fromsrc/launch/mod.rs#[cfg(test)]-guarded unit tests insrc/remain in placeVerification
All 11 other test locations in
src/have proper#[cfg(test)]guards on their parent modules or inlinemod testsblocks.@weter11 can click here to continue refining the PR