Fix 32-bit process initialization in experimental WOW64 mode#55
Conversation
- Added unix-side architecture subdirectories (x86_64-unix, i386-unix) to ARCH_SUBDIRS to support builtin library discovery in modern Wine layouts. - Extended WINEDLLPATH generation in WineTkgRunner to include UNIFIED_BASE_LIB_SUBDIRS (e.g., files/lib) and all architecture-specific subfolders. - Resolves 'cannot find builtin library' errors for 32-bit applications running in experimental WOW64 mode with Proton GE and Proton-CachyOS. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
The issue where 32-bit processes failed in experimental WOW64 mode (specifically failing to find
ntdll.dllinsyswow64) was caused by the launcher not exposing the Unix-side bridge components to Wine's loader.Modern Wine/Proton builds split builtin libraries into Windows PE components (
.dll) and Unix bridge components (.so). In WOW64 mode, the loader expects these Unix components in architecture-specific subdirectories likei386-unix.I have implemented the following changes:
src/proton.rs: ExpandedARCH_SUBDIRSto includex86_64-unixandi386-unix. This allows the launcher to discover the Unix-side stubs required by the loader.src/infra/runners/wine_tkg.rs: Updated theWINEDLLPATHconstruction logic. It now includesUNIFIED_BASE_LIB_SUBDIRS(likefiles/libandfiles/lib64used by modern Proton 11+ and GE/CachyOS) and ensures that all architecture variants (both-windowsand-unix) are added to the search path.These changes ensure that whenever a 32-bit application is launched in a WOW64 environment, Wine can correctly bridge the Windows-side library calls to their native Unix implementations.
PR created automatically by Jules for task 9313677641832686222 started by @weter11