feat: Add repair/reinstall capability for master Steam prefix#53
Closed
weter11 wants to merge 1 commit into
Closed
feat: Add repair/reinstall capability for master Steam prefix#53weter11 wants to merge 1 commit into
weter11 wants to merge 1 commit into
Conversation
- Add repair_master_steam() function that:
- Stops running Steam/wine processes in master prefix
- Backs up existing prefix to master_steam_prefix.bak.<timestamp>
- Keeps only 1 previous backup (deletes oldest before creating new)
- Re-runs install_master_steam() against fresh prefix
- Add UI components:
- 'Repair / Reinstall Windows Steam Runtime' button in Settings
- Confirmation dialog warning about Steam login state
- Progress/status updates via AsyncOp channel
- Add post-launch grace period health check in WineTkgRunner:
- 2-second grace period after ready-signal detection
- Polls try_wait() to verify Steam process still alive
- Detects false-positive scenario where ready-signal exists but
process has crashed (e.g., steamerrorreporter appeared)
- Error message suggests using repair action
- Add unit test for grace-check behavior
- Fix borrow checker issues in UI confirmation dialog
- Fix type mismatch in readiness loop (Option vs bool)
Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds repair/reinstall capability for the master Windows Steam prefix, addressing the issue where corrupted Steam installs could not be recovered through the UI.
Changes
1. Repair Logic (src/launch/mod.rs)
repair_master_steam()function that:master_steam_prefix.bak.<timestamp>install_master_steam()against fresh prefix2. UI Components (src/ui.rs)
3. Post-Launch Grace Period Health Check (src/infra/runners/wine_tkg.rs)
try_wait()to verify Steam process is still alive4. Unit Test (src/launch/verification_tests.rs)
MockSteamFalsePositiveRunnerand test for grace-check behaviorAcceptance Criteria Met