Add repair/reinstall capability for the master Windows Steam prefix#51
Conversation
- Implement `repair_master_steam` in `src/launch/mod.rs` with backup rotation. - Add 2s post-ready grace check in `WineTkgRunner` to detect early Steam crashes. - Expose "Repair Windows Steam Runtime" in Settings UI with confirmation. - Add unit test for background Steam grace check failure. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…time - Fixed `install_master_steam` to create prefix directories before Wine initialization. - Added `backup_master_steam` and `restore_master_steam` logic with prefix rotation (keeping 1 backup). - Implemented a post-ready grace check in background Steam launcher to detect early crashes and suggest repair. - Revamped Settings UI to show context-aware actions: Install, Manage, Repair, Backup, and Restore. - Added confirmation prompts for destructive operations. - Added unit test for background Steam grace period failure. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
- Added `build_bare_wine_command` to bypass Proton bootstrap for Steam client/installer. - Implemented `backup_master_steam` and `restore_master_steam` with rotation logic. - Revamped Settings UI to dynamically show context-aware actions: Install, Manage, Repair, Backup, and Restore. - Added 2s grace check to catch early background Steam crashes. - Ensured prefix directory existence before Wine initialization. - Added automated test for crash detection logic. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
1 participant
Implemented a repair/reinstall capability for the master Windows Steam prefix.
Key changes:
src/launch/mod.rs: Addedrepair_master_steamwhich kills running processes, backs up the current prefix (keeping only one backup), and re-runs the installer.src/infra/runners/wine_tkg.rs: Added a 2-second grace period to the background Steam readiness loop. If Steam signals ready (e.g.,config.vdfcreated) but exits within this window, it's now correctly identified as a crash (steam_process_exited_early).src/ui.rs: Added a dedicated "Repair Windows Steam Runtime" button in the Settings panel with a safety confirmation.src/launch/verification_tests.rs: Added a unit test to verify that the grace period correctly identifies early crashes despite readiness signals.This addresses the issue where a corrupted Steam installation would pass the file-existence readiness heuristic but crash immediately after.
PR created automatically by Jules for task 3693184502652770066 started by @weter11