Report the ground a layout paints - #32
Open
welshofer wants to merge 1 commit into
Open
Conversation
The companion to `Slide.effectiveBackground`, needed from the other end of the same question. Before binding a new slide to a layout, a caller has to know whether that layout is representative of the deck it came from — and measured over 115 real decks, a third carry one layout or none, with their whole look painted on the slides while the layouts and theme stay at the Office defaults. A slide bound to one of those comes out white in a deck that is emphatically not, which is worse than not using the layout at all. Same walk as the slide's, one link shorter: layout, then master. 2 new tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The companion to
Slide.effectiveBackgroundadded in #31, needed from the other end of the same question.Before binding a new slide to a layout, a caller has to know whether that layout is representative of the deck it came from. Measured over 115 real decks: a third carry one layout or none, with their whole look painted on the slides while the layouts and theme stay at the Office defaults. A slide bound to one of those comes out white in a deck that is emphatically not — worse than not using the layout at all.
SlideLayout.effectiveBackgroundruns the same walk as the slide's, one link shorter: layout, then master, resolvingsrgbClr,schemeClrthrough the theme, gradients andp:bgRef.2 new tests.
🤖 Generated with Claude Code