fix: replace self-dividing HighMemoryUsage Prometheus alert expression - #37
Open
Thecesar85 wants to merge 1 commit into
Open
fix: replace self-dividing HighMemoryUsage Prometheus alert expression#37Thecesar85 wants to merge 1 commit into
Thecesar85 wants to merge 1 commit into
Conversation
The HighMemoryUsage alert used process_resident_memory_bytes divided by itself, always evaluating to 1 for any nonzero value. This made the alert rule useless and prevented it from reflecting real memory pressure. Fix: change denominator to machine_memory_bytes so the expression compares process resident memory against total machine memory. Fixes weilixiong#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
HighMemoryUsagePrometheus alert expression: the previous rule usedprocess_resident_memory_bytes / process_resident_memory_bytes > 0.9which is self-dividing and always evaluates to1for any nonzero value — making the alert useless.Change: Replace denominator with
machine_memory_bytesso the expression compares process resident memory against total machine memory.Validation
python3 -c "import ast; ast.parse(open('tools/monitoring_setup.py').read()); print('Syntax OK')"passesprocess_resident_memory_bytes / machine_memory_bytes > 0.9is valid PromQL and fires when memory usage exceeds 90%Fixes #1