fix: replace self-dividing HighMemoryUsage alert expression - #29
Open
lwq19850429 wants to merge 1 commit into
Open
fix: replace self-dividing HighMemoryUsage alert expression#29lwq19850429 wants to merge 1 commit into
lwq19850429 wants to merge 1 commit into
Conversation
The original expression divided process_resident_memory_bytes by itself, which always evaluates to 1 and makes the alert unreliable. Replaced with: process_resident_memory_bytes / node_memory_MemTotal_bytes > 0.9 This correctly compares process memory against total system memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
HighMemoryUsagePrometheus alert expression which incorrectly dividedprocess_resident_memory_bytesby itself, always evaluating to1.Changes
tools/monitoring_setup.pyprocess_resident_memory_bytes / process_resident_memory_bytes > 0.9→process_resident_memory_bytes / node_memory_MemTotal_bytes > 0.9Testing
Bounty
Addresses the [$30 BOUNTY] issue: Fix HighMemoryUsage alert ratio expression